feat: better ingestion timestamp warning #27122
Open
+13
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pauldambra
commented
Dec 22, 2024
| @@ -148,6 +153,8 @@ export class ReplayEventsIngester { | |||
| isValid: asDate.isValid, | |||
| daysFromNow: Math.round(Math.abs(asDate.diffNow('day').days)), | |||
| processingTimestamp: DateTime.now().toISO(), | |||
| eventTypes, | |||
| customEvents, | |||
There was a problem hiding this comment.
these all have small controlled payloads we create so are safe to capture here
pauldambra
commented
Dec 22, 2024
Comment on lines
142
to
143
| type: event.type, | ||
| timestamp: event.timestamp, |
There was a problem hiding this comment.
this will hopefully let me spot any patterns in the bad data, and figure out how I can safely capture a custom event instead of dropping here
benjackwhite
requested changes
Dec 23, 2024
| @@ -138,6 +138,11 @@ export class ReplayEventsIngester { | |||
| if (replayRecord !== null) { | |||
| const asDate = DateTime.fromSQL(replayRecord.first_timestamp) | |||
| if (!asDate.isValid || Math.abs(asDate.diffNow('day').days) >= 7) { | |||
| const eventTypes = rrwebEvents.map((event) => ({ | |||
There was a problem hiding this comment.
Two loops over what could potentially be arrays with 1000s of entries? Given how sensitive blobby is to cpu work, maybe we could:
- Do this in one loop rather than a map and filter
- Wait till after christmas to merge
|
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we reject replay messages if the
first_timestampis invalidbut in some cases the
last_timestampis validwe see this consistently (but at least at a very very low rate). if you have a very short session we might be dropping the only message we see for that session.
i'd like to capture a custom event into the recording instead of totally dropping the payload or we have no way of diagnosing what is happening
i want to capture a little more information since from what i have i can't quite figure out the safe way to capture the event
NB I won't merge this until 6th Jan regardless, since i'm not really working